LCORE-2860: RHOAI Prow e2e tests fail to start — service pods never become ready by are-ces · Pull Request #2050 · lightspeed-core/lightspeed-stack

are-ces · 2026-07-02T10:40:43Z

Summary

Fix two issues preventing RHOAI Prow e2e pipeline from deploying service pods:

Image build failure (DockerBuildFailed): oc new-build --image=ubi9/ubi-minimal overrode the containerfile's FROM ubi9/python-312 with ubi-minimal, which lacks dnf. Removed the --image flag so the containerfile's own base image is used.
Vector store registration conflict: run.yaml pre-registered the vector store and embedding model under provider_id: faiss, conflicting with the lightspeed-stack enrichment script which registers them under provider_id: byok_e2e-test-docs. Removed the duplicate entries since enrichment handles both.

Type of change

Tools used to create PR

Assisted-by: Claude Opus 4.6
Generated by: N/A

Related Tickets & Documents

Closes LCORE-2860

Checklist before requesting a review

I have performed a self-review of my code.
PR has passed all pre-merge test jobs.
If it is a core feature, I have added thorough tests.

Testing

Triggered RHOAI Prow periodic pipeline — llama-stack image builds successfully with ubi9/python-312 base
llama-stack pod starts without vector store registration conflict
lightspeed-stack connects to llama-stack successfully
Verified RAG query returns results via /v1/query

Summary by CodeRabbit

Chores
- Simplified end-to-end test and build setup by removing an unused vector store registration and streamlining the image build configuration.
- No user-facing functionality changes were introduced.

coderabbitai · 2026-07-02T10:41:04Z

Warning

Review limit reached

@are-ces, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 140ac990-6bc0-4f7a-94cf-e060674aa530

📥 Commits

Reviewing files that changed from the base of the PR and between 1834e01 and cac51f2.

📒 Files selected for processing (6)

tests/e2e-prow/rhoai/configs/run.yaml
tests/e2e-prow/rhoai/manifests/lightspeed/lightspeed-stack.yaml
tests/e2e-prow/rhoai/manifests/lightspeed/llama-stack-prow.yaml
tests/e2e-prow/rhoai/pipeline.sh
tests/e2e/configuration/server-mode/lightspeed-stack-rhoai.yaml
tests/e2e/utils/prow_utils.py

Walkthrough

Modifies the RHOAI e2e test configuration to remove an embedding model and FAISS vector store registration, replacing it with an empty vector store list, and removes an explicit base image argument from the pipeline's build step.

Changes

E2E RHOAI Test Config and Pipeline Updates

Layer / File(s)	Summary
Vector store registration removal `tests/e2e-prow/rhoai/configs/run.yaml`	Removed the `all-mpnet-base-v2` embedding model and its FAISS vector store registration (including embedding dimension/model id and vector_store_id), replaced with an empty `vector_stores: []`.
Build image argument removal `tests/e2e-prow/rhoai/pipeline.sh`	Removed the explicit `--image="registry.access.redhat.com/ubi9/ubi-minimal"` argument from the `oc new-build` invocation, leaving the docker strategy to use default image behavior.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

lightspeed-core/lightspeed-stack#1130: Related e2e pipeline build image change involving container build configuration.
lightspeed-core/lightspeed-stack#1800: Related change to the llama-stack e2e test container image build environment.

Suggested reviewers: tisnik, radofuchs

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the e2e startup failure being fixed and matches the changeset's focus.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

✨ Simplify code

Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

tisnik

LGTM

- Remove --image flag from oc new-build that overrode the containerfile's FROM (ubi9/python-312) with ubi-minimal, which lacks dnf - Remove duplicate vector_stores registration from run.yaml (enrichment handles it) - Add RHOAI-specific lightspeed-stack config with vLLM defaults - Parametrize model name via vllm-model-secret so both pods read from a single source - Override inference defaults (default_model/default_provider) in Prow config swaps using E2E env vars - Create /tmp/data before starting lightspeed-stack pod for SQLite Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

are-ces · 2026-07-08T08:52:09Z

Tests running here

tisnik

LGTM

tisnik approved these changes Jul 2, 2026

View reviewed changes

are-ces marked this pull request as draft July 2, 2026 11:05

are-ces marked this pull request as ready for review July 8, 2026 07:56

are-ces force-pushed the lcore-2860-fix-rhoai-pipeline branch from 60939c8 to cac51f2 Compare July 8, 2026 07:59

tisnik approved these changes Jul 8, 2026

View reviewed changes

tisnik merged commit 7d520c9 into lightspeed-core:main Jul 8, 2026
45 of 49 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

LCORE-2860: RHOAI Prow e2e tests fail to start — service pods never become ready#2050

LCORE-2860: RHOAI Prow e2e tests fail to start — service pods never become ready#2050
tisnik merged 1 commit into
lightspeed-core:mainfrom
are-ces:lcore-2860-fix-rhoai-pipeline

are-ces commented Jul 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading

Review limit reached

Uh oh!

tisnik left a comment

Uh oh!

are-ces commented Jul 8, 2026

Uh oh!

tisnik left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

are-ces commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of change

Tools used to create PR

Related Tickets & Documents

Checklist before requesting a review

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

tisnik left a comment

Choose a reason for hiding this comment

Uh oh!

are-ces commented Jul 8, 2026

Uh oh!

tisnik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

are-ces commented Jul 2, 2026 •

edited

Loading

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading